Use TS ESLint's no-invalid-this instead #14458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
bterlson,
chradek,
daviwil,
ellismg,
jeremymeng,
joheredi,
KarishmaGhiya,
mikeharder,
praveenkuttappan,
sadasant,
sarangan12,
schaabs,
southpolesteve,
witemple-msft,
xirzec,
zfoster and
a team
as code owners
ghost
added
Azure.Core
Cosmos
Event Grid
Azure.Identity
KeyVault
Tables
EngSys
|
Hello @deyaaeldeen! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ramya-rao-a
reviewed
Mar 24, 2021
maorleger
reviewed
Mar 25, 2021
|
Removing the auto-merge label so that people have time to review if they want to |
maorleger
approved these changes
Mar 25, 2021
deyaaeldeen
force-pushed
the
linting/use-ts-no-invalid-this
branch
from
00006af to
f3cf265
Compare
ramya-rao-a
approved these changes
Mar 25, 2021
ghost
merged commit
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
Implements the approach described here: Azure#14406 (comment) to linting `this` references. Reminder to myself: look for typescript-eslint alternatives when the behavior of eslint is not satisfactory.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the approach described here: #14406 (comment) to linting
thisreferences. Reminder to myself: look for typescript-eslint alternatives when the behavior of eslint is not satisfactory.